Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on tap listener for multiple advance #12844

Merged
merged 2 commits into from Jan 17, 2018
Merged

add on tap listener for multiple advance #12844

merged 2 commits into from Jan 17, 2018

Conversation

prateekbh
Copy link
Member

#12671
We did not add onTapNavigationListener for MultipleAdvancementConfig. Which prevents next/previous in media and time based navigation.

This fixes it.

@alanorozco alanorozco merged commit 81ad0fe into ampproject:master Jan 17, 2018
@prateekbh prateekbh deleted the manualNavigationMultipleConfigFix branch January 17, 2018 18:05
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants