Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip test that fail with lolex v2 #12858

Merged
merged 1 commit into from Jan 17, 2018
Merged

Unskip test that fail with lolex v2 #12858

merged 1 commit into from Jan 17, 2018

Conversation

zhouyx
Copy link
Contributor

@zhouyx zhouyx commented Jan 17, 2018

Realized all fix are similar. Ended up fix them all : )
cc @lannka @dvoytenko

@zhouyx zhouyx requested a review from rsimha January 17, 2018 00:52
rsimha
rsimha approved these changes Jan 17, 2018
View reviewed changes
Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing these! And sorry I had to disable these tests in the first place. I was upgrading the entire set of unit tests in #12486, and It was tricky to figure out exactly which window was the target in each case.

@zhouyx zhouyx merged commit b5fa389 into ampproject:master Jan 17, 2018
@zhouyx zhouyx deleted the fix-lolex-v2-api branch January 17, 2018 19:01
gzgogo pushed a commit to gzgogo/amphtml that referenced this pull request Jan 26, 2018
@zhouyx @gzgogo
unskip test that fail with lolex v2 (ampproject#12858)
ba675aa
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
@zhouyx @RanAbram
unskip test that fail with lolex v2 (ampproject#12858)
f358000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsimha rsimha rsimha approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zhouyx @rsimha @googlebot @ampprojectbot