New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layers: Scoring Algorithm #12958
Merged
Merged
Layers: Scoring Algorithm #12958
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
74f2aa8
Add comments for future todos
jridgewell 3c0cd40
Ensure size/position is always re-measured
jridgewell 5da0b9f
scoring
jridgewell 12cf144
Fix fixed-position undeclare layer
jridgewell 0ac73ee
Ensure a remeasure happens
jridgewell d06b527
Fix cache and score
jridgewell 5f54a86
Fix width/height calc
jridgewell 4905af5
Add force remeasurement
jridgewell 17cb994
Lint
jridgewell ad1dcec
Review comments
jridgewell fb46356
Review comments
jridgewell b6e82df
Fix renames
jridgewell File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is faster than
typeof
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷♂️