amp-mathml: few fixes and validator tests #13001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
reviewed
Jan 24, 2018
| }); | ||
| }); | ||
|
|
||
| // set data-formula so 3P script case use it. |
| }); | ||
|
|
||
| // set data-formula so 3P script case use it. | ||
| this.element.setAttribute('data-formula', |
There was a problem hiding this comment.
This is a bit confusing. Why have the extra formula attribute if you're just going to use it to set the data-formula attribute and not just use data-formula? Basically what happens if the developer sets the data-formula attribute? We should at least make this clear in the doc.
cathyxz
approved these changes
Jan 24, 2018
This was referenced Jan 26, 2018
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Jan 26, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
* Revision bump for ampproject#12862 * Revision bump for ampproject#13001 * Revision bump for ampproject#12906
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Revision bump for ampproject#12862 * Revision bump for ampproject#13001 * Revision bump for ampproject#12906
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Revision bump for ampproject#12862 * Revision bump for ampproject#13001 * Revision bump for ampproject#12906
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inlineattribute to the documentation