Disable ampCors for analytics remote config XHR in a backward compatible way #13009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer a revert (for cherry pick into prod candidate) and new PR instead of a fix unless this is super urgent. CC @newmuis |
Merged
|
#13012 merged and will be patched to prod. |
zhouyx
approved these changes
Jan 24, 2018
jonkeller
pushed a commit
to jonkeller/amphtml
that referenced
this pull request
Jan 29, 2018
…ble way (ampproject#13009) * Disable ampCors for analytics remote config XHR in a backward compatible way. * Fix test
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…ble way (ampproject#13009) * Disable ampCors for analytics remote config XHR in a backward compatible way. * Fix test
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…ble way (ampproject#13009) * Disable ampCors for analytics remote config XHR in a backward compatible way. * Fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13005