Implements amp-analytics variables, csi pings for page load metrics. #13015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/service/performance-impl.js
Outdated
| // Store certain page visibility metrics to be exposed as analytics variables. | ||
| const storedVal = Math.round(opt_delta != null ? Math.max(opt_delta, 0) | ||
| : value - this.initTime_); | ||
| if (label == 'fcp') { |
There was a problem hiding this comment.
I would make this a switch as it'll be easier to read
|
@keithwrightbos @gskrell This PR seems to have broken Perhaps the tests were not run recently enough? |
|
It's a merge issue with
5fb3da2#diff-775f4cb823bb027213fbff02cfb81778
That one removed the expandAsync() function :(
…On Thu, Jan 25, 2018 at 3:36 PM, Raghu Simha ***@***.***> wrote:
@keithwrightbos <https://github.com/keithwrightbos> @gskrell
<https://github.com/gskrell> This PR seems to have broken gulp lint on
master. https://travis-ci.org/ampproject/amphtml/jobs/333422431#L1698
Perhaps the tests were not run recently enough?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#13015 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACV2BzgCgBmyAvyW-999Vq3DMy25Vkwqks5tOOXTgaJpZM4Rr1Xb>
.
|
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
…mpproject#13015) * Prototype of page load amp analytics variables. * Lint fixes for page load metrics. * Change if statements to switch statement.
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…mpproject#13015) * Prototype of page load amp analytics variables. * Lint fixes for page load metrics. * Change if statements to switch statement.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…mpproject#13015) * Prototype of page load amp analytics variables. * Lint fixes for page load metrics. * Change if statements to switch statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #11378. Implements amp-analytics variables for Make Body Visible, First Contentful Paint, and First Viewport Ready.