Lightbox controls should be actually hidden and not hidden by setting opacity to 0 #13042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
approved these changes
Jan 26, 2018
| @@ -934,7 +904,8 @@ export class AmpLightboxViewer extends AMP.BaseElement { | |||
| this.topBar_.classList.remove('fullscreen'); | |||
| } | |||
| toggle(dev().assertElement(this.carousel_), true); | |||
| this.toggleDescriptionBox_(true); | |||
| this.updateDescriptionBox_(); | |||
There was a problem hiding this comment.
Does this.updatedesciptionBox_ need to be called when this.descriptionBox_ is toggled? It could be good defensive practice to create one method that calls both of them so no one risks forgetting to call this.updatedesciptionBox_ when toggling it.
There was a problem hiding this comment.
True. I'll bring that function back.
aghassemi
approved these changes
Jan 26, 2018
gzgogo
pushed a commit
to gzgogo/amphtml
that referenced
this pull request
Jan 26, 2018
… opacity to 0 (ampproject#13042) * Lightbox controls hidden should be actually hidden and not by opacity * Refactor toggle description and update into a single function
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
… opacity to 0 (ampproject#13042) * Lightbox controls hidden should be actually hidden and not by opacity * Refactor toggle description and update into a single function
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
… opacity to 0 (ampproject#13042) * Lightbox controls hidden should be actually hidden and not by opacity * Refactor toggle description and update into a single function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #12993.