Sync Lightbox with Carousel #13050
Merged
Sync Lightbox with Carousel #13050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
force-pushed
the
feature/sync-lightbox-carousel
branch
from
5f1dcaa
to
e700c75
Compare
cvializ
approved these changes
Jan 26, 2018
| * mapping of the lightbox group id to the carousel element. | ||
| * @private {!Object<string, !Element>} | ||
| */ | ||
| this.lightboxSourceCarousels_ = {}; |
There was a problem hiding this comment.
This might need to be a src/object.js#map to speed up lookups. map is prototypeless so failed lookups happen faster. In the AMP codebase I see we generally prefer maps and map[key] notation vs {} literals and hasOwnProperty.
There was a problem hiding this comment.
Discussed this and yes you're right. This should happen for security reasons too, not just performance.
|
Actually I realized that I forgot to handle a pretty major edge case here, which is making sure that sync-ing still behaves properly when we exclude items from the lightbox. Going to add logic for that. |
cathyxz
force-pushed
the
feature/sync-lightbox-carousel
branch
from
267f996
to
9249058
Compare
cathyxz
force-pushed
the
feature/sync-lightbox-carousel
branch
from
9249058
to
d6daf5d
Compare
jonkeller
pushed a commit
to jonkeller/amphtml
that referenced
this pull request
Jan 29, 2018
* Sync slides to lightbox * Only exit if you're going back to your original element or you're a sync-ed carousel * Exclude scroll carousel * Add null check to shouldAnimate * Handle excluding elements from lightbox
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Sync slides to lightbox * Only exit if you're going back to your original element or you're a sync-ed carousel * Exclude scroll carousel * Add null check to shouldAnimate * Handle excluding elements from lightbox
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Sync slides to lightbox * Only exit if you're going back to your original element or you're a sync-ed carousel * Exclude scroll carousel * Add null check to shouldAnimate * Handle excluding elements from lightbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12578 and #13052