Document batchPlugin and how vendor add their plugin #13065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Jan 28, 2018
| */ | ||
| function ping(unusedBaseUrl, unusedSegments) { | ||
| function ping(unusedBaseUrl, unusedBatchSegments) { |
There was a problem hiding this comment.
do you want to rename? like forTest or fake
zhouyx
force-pushed
the
document-batching
branch
from
34d3c1e
to
f1fb066
Compare
|
PTAL : ) cc @pomeroyr |
pomeroyr
approved these changes
Feb 1, 2018
ghost
suggested changes
Feb 1, 2018
| @@ -28,6 +29,7 @@ Before you can add your analytics service to AMP HTML runtime, you may need to: | |||
| 1. "optout": if needed. We currently don't have a great opt-out system, so please reach out to help us design one that works well for you. | |||
| 1. An example in the [examples/analytics-vendors.amp.html](../../examples/analytics-vendors.amp.html) | |||
| reference. | |||
| 1. A new batch plugin if required. Please refer to | |||
ghost
approved these changes
Feb 1, 2018
zhouyx
force-pushed
the
document-batching
branch
from
82888cb
to
cd666e1
Compare
lannka
approved these changes
Feb 3, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
* document batching features * add reportWindow * minor fixes * add refer to * fix test
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* document batching features * add reportWindow * minor fixes * add refer to * fix test
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* document batching features * add reportWindow * minor fixes * add refer to * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementations merged. Ready to be reviewed.