Remove the flash on story pages transitions. #13070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
force-pushed
the
ios_tap_flash
branch
from
b1077ab
to
e30e06a
Compare
newmuis
reviewed
Jan 27, 2018
|
|
||
| // Remove the cursor: pointer; style set by the runtime, to avoid wrong | ||
| // touch feedback on mobile, like a flashing overlay on page transitions. | ||
| resetStyles(this.win.document.documentElement, ['cursor']); |
There was a problem hiding this comment.
I think it should be sufficient to do this in the "standalone" case (where amp-story is the only tag in the document), where we add the CSS class .i-amphtml-story-standalone to the document element anyway. So, maybe in the CSS we can just add:
.i-amphtml-story-standalone {
cursor: default !important;
}
435dc21
to
e2f7c84
Compare
gmajoulet
commented
Jan 29, 2018
|
|
||
| // Remove the cursor: pointer; style set by the runtime, to avoid wrong | ||
| // touch feedback on mobile, like a flashing overlay on page transitions. | ||
| resetStyles(this.win.document.documentElement, ['cursor']); |
newmuis
approved these changes
Jan 29, 2018
gmajoulet
force-pushed
the
ios_tap_flash
branch
from
e2f7c84
to
453dc3e
Compare
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Remove the flash on story page transitions. * Removing the iOS cursor: pointer on standalone stories only.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Remove the flash on story page transitions. * Removing the iOS cursor: pointer on standalone stories only.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the flash on story pages transitions.
From this, to this.
There's another known hack to get rid of this overlay, but it'd break tap feedback on all the elements, including links or forms if we ever support it.