Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing some experimental features #13076

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Removing some experimental features #13076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions build-system/amp.extern.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,3 +425,13 @@ var rtcResponseDef;
* @type {!function(string):?}
*/
AMP.require;

/**
* TransitionDef function that accepts normtime, typically between 0 and 1 and
* performs an arbitrary animation action. Notice that sometimes normtime can
* dip above 1 or below 0. This is an acceptable case for some curves. The
* second argument is a boolean value that equals "true" for the completed
* transition and "false" for ongoing.
* @typedef {function(number, boolean):?|function(number):?}
*/
var TransitionDef;
30 changes: 0 additions & 30 deletions build-system/amp.nti.extern.js
View file
Open in desktop

This file was deleted.

27 changes: 0 additions & 27 deletions build-system/amp.oti.extern.js
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions build-system/tasks/compile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,20 +311,6 @@ function compile(entryModuleFilenames, outputDir,
'globalThis');
compilerOptions.compilerFlags.conformance_configs =
'build-system/conformance-config.textproto';

// TODO(aghassemi): Remove when NTI is the default.
if (argv.nti) {
compilerOptions.compilerFlags.new_type_inf = true;
compilerOptions.compilerFlags.jscomp_off.push(
'newCheckTypesExtraChecks');
compilerOptions.compilerFlags.externs.push(
'build-system/amp.nti.extern.js'
);
} else {
compilerOptions.compilerFlags.externs.push(
'build-system/amp.oti.extern.js'
);
}
}
if (argv.pseudo_names) {
compilerOptions.compilerFlags.define.push('PSEUDO_NAMES=true');
Expand Down