Tweak the Git instructions #13112
Merged
Tweak the Git instructions #13112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are easier ways to handle a few of the tasks in the contributing instructions. In particular, it's best to have master track upstream, since otherwise you have two separate remote masters to keep track of. Additionally, a few instructions (like the first git push) don't quite work as currently specified; this fixes them.
taymonbeal
force-pushed
the
git-advice
branch
from
aea4785
to
4b0fbac
Compare
|
Looks good to me. ccing @camelburrito and @erwinmombay who wrote the original onboarding doc with git commands in case they have any thoughts. |
mrjoro
approved these changes
Feb 6, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
There are easier ways to handle a few of the tasks in the contributing instructions. In particular, it's best to have master track upstream, since otherwise you have two separate remote masters to keep track of. Additionally, a few instructions (like the first git push) don't quite work as currently specified; this fixes them.
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
There are easier ways to handle a few of the tasks in the contributing instructions. In particular, it's best to have master track upstream, since otherwise you have two separate remote masters to keep track of. Additionally, a few instructions (like the first git push) don't quite work as currently specified; this fixes them.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
There are easier ways to handle a few of the tasks in the contributing instructions. In particular, it's best to have master track upstream, since otherwise you have two separate remote masters to keep track of. Additionally, a few instructions (like the first git push) don't quite work as currently specified; this fixes them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are easier ways to handle a few of the tasks in the contributing instructions. In particular, it's best to have master track upstream, since otherwise you have two separate remote masters to keep track of. Additionally, a few instructions (like the first git push) don't quite work as currently specified; this fixes them.