Enable adding analytics to template ad #13114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
force-pushed
the
template-ad-custom-analytics
branch
2 times, most recently
from
138f65c
to
3d118c0
Compare
lannka
requested changes
Jan 30, 2018
| @@ -75,7 +78,39 @@ export class AmpAdTemplates { | |||
| */ | |||
| render(templateValues, element) { | |||
| return Services.templatesFor(this.win_) | |||
| .findAndRenderTemplate(element, templateValues); | |||
| .findAndRenderTemplate(element, templateValues) | |||
| .then(renderedElement => { | |||
| (isArray(analyticsValue) ? analyticsValue : [analyticsValue]); | ||
| for (let i = 0; i < analyticsValue.length; i++) { | ||
| const config = analyticsValue[i]; | ||
| const analyticsEle = document.createElement('amp-analytics'); |
There was a problem hiding this comment.
should you use element.owenerDocument
| } | ||
| if (config['inline']) { | ||
| const scriptElem = createElementWithAttributes( | ||
| document, |
| @@ -151,6 +151,18 @@ export class AmpAdNetworkAdzerkImpl extends AmpA4A { | |||
|
|
|||
| /** @override */ | |||
| getAmpAdMetadata(unusedCreative) { | |||
| if (this.ampCreativeJson_.analytics) { | |||
There was a problem hiding this comment.
should you just load the analytics extension?
There was a problem hiding this comment.
I prefer not to load the extension here. AmpA4A will load extension based on metadata, I think it's better to load all extensions together.
There was a problem hiding this comment.
Talked offline. It's not that straightforward to load extension here. Will keep the current approach.
lannka
approved these changes
Jan 30, 2018
zhouyx
force-pushed
the
template-ad-custom-analytics
branch
from
49b7db4
to
404d22e
Compare
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* enable adding analytics to template * fix type check * rename * address comment * linter * fix test
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* enable adding analytics to template * fix type check * rename * address comment * linter * fix test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Insert
<amp-analytics>component to template ad.creativeJson should be defined like