Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-with-direction to the latest version 馃殌 #13131

Merged
merged 2 commits into from Jan 30, 2018

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Jan 30, 2018

Version 1.3.0 of react-with-direction was just published.

Dependency react-with-direction
Current Version 1.1.0
Type devDependency

The version 1.3.0 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of react-with-direction.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 17 commits.

  • 0b6625c Version 1.3.0
  • 90fdffc Merge pull request #8 from airbnb/garrett--auto-direction
  • 6d93ac8 Address PR feedback
  • ad2095a [AutoDirectionProvider] Add component for automatically detected direction
  • 1339e80 Merge pull request #7 from airbnb/garrett--test-watch
  • 24c969a Add test:watch script
  • a95cead [Deps] update object.assign
  • 124edfe [Dev Deps] remove react-test-renderer
  • 76c10eb [Dev Deps] update casual, enzyme, enzyme-adapter-react-helper, eslint, eslint-plugin-import, eslint-plugin-jsx-a11y, eslint-plugin-react, sinon, webpack
  • 7949adf Add build script to prepublish
  • 721653e Version 1.2.0
  • 936937e Merge pull request #4 from airbnb/add_inline_prop
  • 94d093c [DirectionProvider] add an inline prop
  • 9b4b1ca [Dev Deps] update enzyme, eslint, sinon
  • e51d7f9 Merge pull request #3 from airbnb/use_adapter_helper

There are 17 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@googlebot
Copy link

So there's good news and bad news.

馃憤 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

馃槙 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@rsimha
Copy link
Contributor

rsimha commented Jan 30, 2018

/to @cramforce

@cramforce cramforce merged commit 3793868 into master Jan 30, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/react-with-direction-1.3.0 branch January 30, 2018 04:39
@rsimha
Copy link
Contributor

rsimha commented Jan 30, 2018

/cc @cvializ @erwinmombay to make sure this upgrade is okay. Also, sanity check: does react-with-direction actually belong in devDependencies?

@cvializ
Copy link
Contributor

cvializ commented Jan 30, 2018

Ah I don't think it is currently used. It might be left over from an older version of react-dates that used it as a dependency.

@cramforce
Copy link
Member

Please clean up!

@rsimha
Copy link
Contributor

rsimha commented Feb 1, 2018

Clean up done in #13067.

RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* chore(package): update react-with-direction to version 1.3.0

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
* chore(package): update react-with-direction to version 1.3.0

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants