Update jsdom to the latest version 馃殌 #13132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greenkeeper[bot]](https://avatars.githubusercontent.com/in/505?s=60&v=4){kind=small}
|
So there's good news and bad news. 馃憤 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 馃槙 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
rsimha
approved these changes
Jan 30, 2018
|
/to @cramforce |
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* chore(package): update jsdom to version 11.6.2 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* chore(package): update jsdom to version 11.6.2 * chore(package): update lockfile https://npm.im/greenkeeper-lockfile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 11.6.2 of jsdom was just published.
The version 11.6.2 is not covered by your current version range.
If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.
It might be worth looking into these changes and trying to get this project onto the latest version of jsdom.
If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.
Commits
The new version differs by 4 commits.
1cd4831Version 11.6.271dc01bUpdate maintainer and repository informationf32113bFurther fix <style> and <script> evaluation semanticsdbda070Fix <style> and <script> parsing to wait for their close tagSee the full diff
FAQ and help
There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.
Your Greenkeeper bot 馃尨