Adjust entry animation for non-transition images #13133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathyxz
commented
Jan 30, 2018
| @@ -771,6 +771,8 @@ export class AmpLightboxViewer extends AMP.BaseElement { | |||
| anim.add(0.9, tr.setStyles(transLayer, { | |||
| opacity: tr.numeric(1, 0.01), | |||
| }), 0.1, EXIT_CURVE_); | |||
| } else { | |||
There was a problem hiding this comment.
In QA Round 3 we decided that it was weird for the black background to fade in first. Originally, setting carousel opacity to 0 was implemented to avoid the transition image moving towards an image that already existed. If that transition is not happening, then we shouldn't set the carousel opacity to zero.
aghassemi
approved these changes
Jan 30, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the entire image to fade in along with the black background.