UX Polish for Lightbox #13147
Merged
UX Polish for Lightbox #13147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
approved these changes
Jan 30, 2018
| @@ -293,6 +293,7 @@ export class AmpLightboxViewer extends AMP.BaseElement { | |||
| this.carousel_ = this.win.document.createElement('amp-carousel'); | |||
| this.carousel_.setAttribute('type', 'slides'); | |||
| this.carousel_.setAttribute('layout', 'fill'); | |||
| this.carousel_.setAttribute('loop', ''); | |||
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Make lightbox carousels loop * Add cursor: pointer to lightbox gallery images
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Make lightbox carousels loop * Add cursor: pointer to lightbox gallery images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a summary PR for code-trivial UX changes that we decided in the last round of QA. Anything that still requires discussion will happen after UX OH today.
cursor: pointerto images in lightbox gallery.