Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make exec.spawnProcess work across platforms #13156

Merged
merged 2 commits into from Jan 31, 2018
Merged

Make exec.spawnProcess work across platforms #13156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54fca08
Make exec.spawnProcess work across platforms
rsimha Jan 30, 2018
02745a1
Restore shell command, since 'shell: true' didn't work
rsimha Jan 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion build-system/exec.js
View file
Open in desktop
Expand Up @@ -21,6 +21,9 @@

const childProcess = require('child_process');

const shellCmd = (process.platform == 'win32') ? 'cmd' : '/bin/sh';
const shellFlag = (process.platform == 'win32') ? '/C' : '-c';

/**
* Spawns the given command in a child process with the given options.
*
Expand All @@ -29,7 +32,7 @@ const childProcess = require('child_process');
* @return {<Object>} Process info.
*/
function spawnProcess(cmd, options) {
return childProcess.spawnSync('/bin/sh', ['-c', cmd], options);
return childProcess.spawnSync(shellCmd, [shellFlag, cmd], options);
}

/**
Expand Down