Deobfuscate string cleanup while expanding URLs #13162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
Jan 31, 2018
src/service/url-expander/expander.js
Outdated
| @@ -134,6 +134,9 @@ export class Expander { | |||
| if (!ignoringChars) { | |||
| ignoringChars = true; | |||
| nextArgShouldBeRaw = true; | |||
| user().assert(builder === '' || builder === ' ', | |||
There was a problem hiding this comment.
do you think we should allow n number of whitespaces? I was trying to prevent this:
REPLACE(hello-world, `-`)
edit: github wont let me do it lol. Basically a bunch of whitespace between first and second arg
There was a problem hiding this comment.
It's currently allowed.
jridgewell
approved these changes
Jan 31, 2018
lannka
approved these changes
Jan 31, 2018
|
can you add a test case? expect().to.throw() |
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Deobfuscate url string cleanup * Clean up check * write test * fix test
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
* Deobfuscate url string cleanup * Clean up check * write test * fix test
This was referenced Oct 8, 2021
This was referenced Feb 25, 2022
This was referenced Feb 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user gives a bad input like
REPLACE(vanishing`hello-word`, `-`)the stringvanishingwill get removed. Instead of swallowing the error we should tell the user.Open to bike-shedding about the actual warning sentence.