Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the check for custom-template declaration #13165

Merged
merged 2 commits into from Jan 31, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Jan 31, 2018

This sanity check would potentially break dynamically loaded custom-template, for example from an FIE ad.

Like custom-element, we should just rely on validator to do the job.

@zhouyx
Copy link
Contributor

zhouyx commented Jan 31, 2018

Do we have validator check on template type now?
Without the check, we could end up with a lot of unresolved promise. I still think we should perform the check but not throw error. Or at least timeout the promise.

@lannka
Copy link
Contributor Author

lannka commented Jan 31, 2018

validator does check it

@lannka lannka merged commit 19cc29c into ampproject:master Jan 31, 2018
@lannka lannka deleted the dont-check-template branch January 31, 2018 17:41
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* Removes the check for custom-template declaration

* remove test
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
* Removes the check for custom-template declaration

* remove test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants