Adding a new ad network - AdPicker

[Shun0750]

We added our ad network "AdPicker".
Could you review our commits?

• We signed a CLA. (Google group name: hitokuse)
• We integrated renderStart and noContent API
• All tests have passed.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
• If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
• In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

[Shun0750]

I signed it! (Google group name: hitokuse)

[googlebot]

CLAs look good, thanks!

[zhouyx]

Looks good in general. Few comments.

[zhouyx]

nit: encodeURIComponent(data.ph)?

[zhouyx]

FYI: It is not always the case that AMP require both width and height. Please refer to supported amp-ad doc here.
Please only specify parameters required by your ad network here. If you want to add instructions on how to use the <amp-ad>, you can refer to our README here.

[zhouyx]

nit: indentation.

[zhouyx]

I tried to test with your ad. But it returns a no content ad to me. Could you provide a fake/demo ad example here for us to test. Thanks.

[Shun0750]

Thank you so much for your review @zhouyx !!
I checked your review and I fixed all the requirements, as well as added a sample ad creative for testing.
I would really appreciated it, if you could check it again.

[zhouyx]

@Shun0750 Looks good. I have one final comment. Please let me know if I should merge this PR. Thanks.

[zhouyx]

Please see my comment before

FYI: It is not always the case that AMP require both width and height. Please refer to supported amp-ad doc here.

Is there a reason that you require width and height to be set? Or is there a reason that you want to document them here? Otherwise we would generally not advice you to document these two attribute here because they are not specific to your adpicker ad network.

I'll leave the final decision to you.

[Shun0750]

@zhouyx Thank you so much for your review! I removed width/height requirements according to your advice.

[zhouyx]

@Shun0750 Thanks for the Pull Request! Merged!