Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw user error during attribute sanitization #13176

Merged
merged 1 commit into from Jan 31, 2018
Merged

Throw user error during attribute sanitization #13176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sanitizer.js
View file
Open in desktop
Expand Up @@ -278,6 +278,8 @@ export function sanitizeHtml(html) {
const attrName = attribs[i];
const attrValue = attribs[i + 1];
if (!isValidAttr(tagName, attrName, attrValue)) {
user().error(TAG, `Removing "${attrName}" attribute with invalid `
+ `value in <${tagName} ${attrName}="${attrValue}">.`);
continue;
}
emit(' ');
Expand Down Expand Up @@ -357,7 +359,6 @@ export function sanitizeFormattingHtml(html) {
* @return {boolean}
*/
export function isValidAttr(tagName, attrName, attrValue) {

// "on*" attributes are not allowed.
if (startsWith(attrName, 'on') && attrName != 'on') {
return false;
Expand Down