Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document usage of --noextensions and --extensions #13246

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Document usage of --noextensions and --extensions #13246

merged 3 commits into from
Feb 2, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 2, 2018

Documentation that's visible during use is best documentation.

Follow up to #13203

@rsimha rsimha self-assigned this Feb 2, 2018
@rsimha rsimha requested a review from zhouyx February 2, 2018 22:48
@rsimha
Copy link
Contributor Author

rsimha commented Feb 2, 2018

/to @zhouyx

Copy link
Contributor

@zhouyx zhouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsimha rsimha merged commit 78dd8be into ampproject:master Feb 2, 2018
@rsimha rsimha deleted the 2018-02-02-DocumentExtensions branch February 2, 2018 23:24
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants