Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run lint and presubmit on gulpfile.js #13258

Merged
merged 6 commits into from
Feb 5, 2018
Merged

Run lint and presubmit on gulpfile.js #13258

merged 6 commits into from
Feb 5, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 4, 2018

This PR:

  1. Enables lint and presubmit checks for gulpfile.js
  2. Fixes all existing lint and presubmit errors in gulpfile.js
  3. Makes minor improvements to presubmit rules
  4. Shortens the help messages printed by gulp [default|watch|build|dist].

Fixes #13257

@rsimha rsimha self-assigned this Feb 4, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Feb 4, 2018

/to @cramforce @erwinmombay

@rsimha rsimha merged commit a0f855b into ampproject:master Feb 5, 2018
@rsimha rsimha deleted the 2018-02-04-GulpChecks branch February 5, 2018 23:54
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants