amp-fx-collection: documentation #13268
Conversation
| </tr> | ||
| <tr> | ||
| <td class="col-fourty"><strong><a href="https://www.ampproject.org/docs/guides/responsive/control_layout.html">Supported Layouts</a></strong></td> | ||
| <td>None</td> |
There was a problem hiding this comment.
None or nodisplay? I've seen nodisplay a couple of times, e.g. in amp-image-lightbox that I'm currently heavily referencing...
| </tr> | ||
| <tr> | ||
| <td width="40%"><strong>Examples</strong></td> | ||
| <td>See AMP By Example's <a href="https://ampbyexample.com/components/amp-fx-collection/">annotated amp-fx-collection</a> example.</td> |
There was a problem hiding this comment.
- If there's no example, consider removing the row until there is one.
| - A value less than 1 scrolls the element downward (element scrolls slower) when the user scrolls downward. | ||
| - A value of 1 behaves normally. | ||
| - A value of 0 effectively makes the element scroll fixed with the page. | ||
|
|
There was a problem hiding this comment.
Please add a validation section (that's standard for component docs) (example: https://github.com/ampproject/amphtml/blob/master/extensions/amp-video/amp-video.md#validation).
| - A value less than 1 scrolls the element downward (element scrolls slower) when the user scrolls downward. | ||
| - A value of 1 behaves normally. | ||
| - A value of 0 effectively makes the element scroll fixed with the page. | ||
|
|
There was a problem hiding this comment.
As this component uses common-extension-attrs, please include the section for "common attributes", like in this component -> https://github.com/ampproject/amphtml/blob/master/extensions/amp-video/amp-video.md#common-attributes
There was a problem hiding this comment.
it does not use any of the common attributes ( actually it is not a components itself, the extensions allows the use of amp-fx attribute. There is no <amp-fx-collection> tag per say)
|
@bpaduch all done, PTAL |
No description provided.