🐛🖍️ Preventing publishers CSS from overriding stories system layer and bookend. #13270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
changed the title
newmuis
reviewed
Feb 5, 2018
| @@ -123,6 +123,20 @@ amp-story[standalone]:fullscreen { | |||
| background-color: rgba(0, 0, 0, 0.2) !important; | |||
| } | |||
|
|
|||
| .i-amphtml-story-system-reset, | |||
| .i-amphtml-story-system-reset * { | |||
| border: none !important; | |||
There was a problem hiding this comment.
Did you try all? Do we know if that's a reasonable approach or not?
There was a problem hiding this comment.
As discussed offline, all wouldn't let us override properties.
…on and unsupported browser.
gmajoulet
commented
Feb 5, 2018
| @@ -123,6 +123,20 @@ amp-story[standalone]:fullscreen { | |||
| background-color: rgba(0, 0, 0, 0.2) !important; | |||
| } | |||
|
|
|||
| .i-amphtml-story-system-reset, | |||
| .i-amphtml-story-system-reset * { | |||
| border: none !important; | |||
There was a problem hiding this comment.
As discussed offline, all wouldn't let us override properties.
newmuis
approved these changes
Feb 6, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
…d bookend. (ampproject#13270) * Preventing CSS overrides. * Preventing CSS overrides for the navigation hint, landscape orientation and unsupported browser.
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…d bookend. (ampproject#13270) * Preventing CSS overrides. * Preventing CSS overrides for the navigation hint, landscape orientation and unsupported browser.
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…d bookend. (ampproject#13270) * Preventing CSS overrides. * Preventing CSS overrides for the navigation hint, landscape orientation and unsupported browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we are able to render the system layer and bookend into shadow DOM, here is a temporary fix.
Related-to #12917