Increase button tap target size and ghost image on enter #13278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvializ
approved these changes
Feb 6, 2018
| div.amp-lbg-button-close, | ||
| div.amp-lbg-button-gallery, | ||
| div.amp-lbg-button-slide { | ||
| div.i-amphtml-lbg-gallery { |
There was a problem hiding this comment.
nit, general CSS style: unless the div is needed to increase specificity, you can drop it. It can make overriding the rule's properties weird later when you just want to specify a single class for the overriding selector.
There was a problem hiding this comment.
Lol. It's in a media query and therefore needed for the specificity...
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
…13278) * Increase button tap target size * Fix desktop mode top padding * tweak button padding to 16px per mulptiple of 4 * Reorder media queries
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
…13278) * Increase button tap target size * Fix desktop mode top padding * tweak button padding to 16px per mulptiple of 4 * Reorder media queries
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
…13278) * Increase button tap target size * Fix desktop mode top padding * tweak button padding to 16px per mulptiple of 4 * Reorder media queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.