✨🏗 add cssBinaries options for extra css outputs for an extension

[erwinmombay]

option will look like:

declareExtension('amp-user-notification', '0.1', {
  hasCss: true,
  cssBinaries: ['my-second-css']
});

[dreamofabear]

@newmuis Is amp-story still using the shadow DOM approach for style isolation?

[dreamofabear]

IMO this should be extracted and called in buildExtension instead.

[rsimha]

We already have a function called buildExtension: https://github.com/ampproject/amphtml/blob/master/gulpfile.js#L508

Just re-read the above comment. Never mind :)

[erwinmombay]

done.

[dreamofabear]

Nit: I think this is a bit more readable.

.then(() => writeCssBinaries(`${name}-${version}.css`)) 

[erwinmombay]

i would need to write it as .then(css => writeCssBinaries(`${name}-${version}.css`, css))
to get the equivalent. (I'm ok with rewriting it to this)

[erwinmombay]

done.

[newmuis]

@choumx We would like to use shadow DOM for isolation, but are blocked by this

[rsimha]

This is a declaration for the same key that's currently being used in buildExtensions, correct?

[erwinmombay]

i think so. i was having a hard time tracking if its still the same options object but i believe so

[rsimha]

I suppose testing with --files should make it clear.

[rsimha]

Also, it's worth testing this code with a couple variations of gulp | gulp dist --fortesting with the args --noextensions | --extensions=minimal_set since that behavior depends on CSS compilation.

[erwinmombay]

done. tested

[rsimha]

We already have a function called buildExtension: https://github.com/ampproject/amphtml/blob/master/gulpfile.js#L508

Just re-read the above comment. Never mind :)

[newmuis]

/cc @gmajoulet

[rsimha]

FYI, @zhouyx is making some changes to how the CSS in extensions are built during gulp dist --noextensions in #13285, so the changes in the two PRs will likely need to be reconciled.

[rsimha]

I suppose testing with --files should make it clear.