Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resets and disables touch zoom for amp stories. #13316

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Resets and disables touch zoom for amp stories. #13316

merged 1 commit into from
Feb 7, 2018

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented Feb 6, 2018

馃悰

  • Resets and disables touch zoom for amp-stories using the viewport.

Fixes #13309

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@newmuis newmuis self-requested a review February 7, 2018 02:40
newmuis
newmuis approved these changes Feb 7, 2018
View reviewed changes
Copy link
Contributor

@newmuis newmuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @Enriqe!

@Enriqe
Copy link
Contributor Author

Enriqe commented Feb 7, 2018

Fixing CLA check: Added my email in the commit. Checking if this works...

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 7, 2018
@newmuis newmuis merged commit b630522 into ampproject:master Feb 7, 2018
@newmuis newmuis mentioned this pull request Feb 20, 2018
Closed
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
@Enriqe
Resets and disables touch zoom for amp stories. (ampproject#13316)
b189fc2
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
@Enriqe @RanAbram
Resets and disables touch zoom for amp stories. (ampproject#13316)
3024ef5
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
@Enriqe
Resets and disables touch zoom for amp stories. (ampproject#13316)
b416fe0
@Enriqe Enriqe deleted the testing branch April 27, 2018 16:01
@gmajoulet gmajoulet mentioned this pull request Sep 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newmuis newmuis newmuis approved these changes

Assignees
No one assigned
Labels
cla: yes PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Enriqe @googlebot @newmuis @ampprojectbot