Fix flaky Karma startup by refreshing the wd cache
#13328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
requested review from
erwinmombay,
keithwrightbos,
jonkeller and
dreamofabear
|
/to @danielrozenberg |
danielrozenberg
approved these changes
Feb 7, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
This was referenced Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mitigates the well-known
Karmastartup issue karma-runner/karma-sauce-launcher#117 by manually refreshing thewdcache innode_modules/wd/buildbefore trying to launch aKarmaserver, as described in admc/wd#466 (comment)This PR essentially repeats what is done when
wdis installed for the first time: https://github.com/admc/wd/blob/master/package.json#L84.Tested by manually deleting the files in
node_modules/wd/buildand runninggulp test. The cache is auto-refreshed byruntime-test.jsprior toKarmastartup. This should greatly reduce flakiness on Travis.Follow up to #10966