Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the runtime is built via
gulp build
, the following directories are generated and included withgulp test --a4a
viabuild-system/config.commonTestPaths
:One of these files was messing with the logger, causing test failures when
gulp test --a4a
was run aftergulp build
.None of these files are actually needed to run the A4A unit tests (or any unit tests for that matter), and they should be removed from the list of test files. With this PR,
gulp test --a4a
works irrespective of the runtime-built-or-not-built initial condition.We should probably follow this up with another PR that removes unnecessary test files from the other
gulp test --unit
variations so that they too run without being influenced by the runtime-built-or-not-built initial condition.Fixes #12135