Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp test --a4a #13331

Merged
merged 1 commit into from
Feb 7, 2018
Merged

Fix gulp test --a4a #13331

merged 1 commit into from
Feb 7, 2018

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 7, 2018

When the runtime is built via gulp build, the following directories are generated and included with gulp test --a4a via build-system/config.commonTestPaths:

'test/fixtures/*.html',
'test/fixtures/served/*.html',
'dist/**/*.js',
'dist.tools/**/*.js',
'examples/**/*',
'dist.3p/**/*',
'test/coverage/**/*',

One of these files was messing with the logger, causing test failures when gulp test --a4a was run after gulp build.

None of these files are actually needed to run the A4A unit tests (or any unit tests for that matter), and they should be removed from the list of test files. With this PR, gulp test --a4a works irrespective of the runtime-built-or-not-built initial condition.

We should probably follow this up with another PR that removes unnecessary test files from the other gulp test --unit variations so that they too run without being influenced by the runtime-built-or-not-built initial condition.

Fixes #12135

@rsimha rsimha self-assigned this Feb 7, 2018
@rsimha
Copy link
Contributor Author

rsimha commented Feb 7, 2018

/to @bradfrizzell

@rsimha
Copy link
Contributor Author

rsimha commented Feb 7, 2018

/to @erwinmombay

@bradfrizzell
Copy link
Contributor

LGTM! Thank you!!!

@rsimha rsimha merged commit 3d54a68 into ampproject:master Feb 7, 2018
@rsimha rsimha deleted the 2018-02-06-A4A branch February 7, 2018 14:20
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failed to call initLogConstructor problem in testing
4 participants