🏗️ Don't pre-launch headless chrome on Travis #13410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/to @danielrozenberg Let's see if the Travis runs for this PR look good. Edit: They do! |
rsimha
changed the title
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Feb 26, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
protonate
pushed a commit
to protonate/amphtml
that referenced
this pull request
Mar 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now use the
chromeaddon on Travis instead of installinggoogle-chrome-stable, and start a headless background instance of Chrome before tests are run.This causes messages like https://travis-ci.org/ampproject/amphtml/jobs/339625462#L747 during Travis VM shutdown. While this doesn't affect testing, it's not a clean exit.
In any case, we start an
xvfbinstance, making the headless-ness of Chrome moot. Moreover, the AMP tests start their own instance of Chrome.Follow up to #13396