Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec update: Inline templates in amp-story-auto-ads #13412

Merged
merged 1 commit into from Feb 9, 2018

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Feb 9, 2018

A minor spec change according to the review with @newmuis

Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Seems more self-contained.

@lannka lannka merged commit cab8817 into ampproject:master Feb 9, 2018
@lannka lannka deleted the template-story-auto-ads branch February 9, 2018 22:58
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants