Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sinon to the latest version 馃殌 #13423

Merged
merged 2 commits into from Feb 21, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Feb 10, 2018

Version 4.2.3 of sinon was just published.

Dependency sinon
Current Version 4.1.3
Type devDependency

The version 4.2.3 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of sinon.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 89 commits.

  • b5968ab Update docs/changelog.md and set new release id in docs/_config.yml
  • 9cbf3f2 Add release documentation for v4.2.3
  • 45cf330 4.2.3
  • 8f54d73 Update History.md and AUTHORS for new release
  • a401b34 Update package-lock.json
  • a21e4f7 Replace formatio with @sinonjs/formatio
  • f4e44ac Use comments in pull request template to get better descriptions with less template text
  • c2f44b0 Update docs/changelog.md and set new release id in docs/_config.yml
  • c76cf01 Add release documentation for v4.2.2
  • 6628080 4.2.2
  • 47b9ba9 Update History.md and AUTHORS for new release
  • 5920e1d Remove mention of PhantomJS from CONTRIBUTING.md
  • 3551fdf Fix #1638: Make resetHistory work for props also
  • b37820a Fix poor test of resetHistory
  • a8171c3 Update docs/changelog.md and set new release id in docs/_config.yml

There are 89 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@googlebot
Copy link

So there's good news and bad news.

馃憤 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

馃槙 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

greenkeeper bot added a commit that referenced this pull request Feb 10, 2018
@greenkeeper
Copy link
Contributor Author

greenkeeper bot commented Feb 10, 2018

Version 4.3.0 just got published.

Update to this version instead 馃殌

Commits

The new version differs by 9 commits.

  • f7139e7 Update docs/changelog.md and set new release id in docs/_config.yml
  • 0b75f10 Add release documentation for v4.3.0
  • 66603e7 4.3.0
  • 2bee64e Update History.md and AUTHORS for new release
  • c45032e Update package-lock.json
  • c27e714 add docs
  • 5459212 add calledOnceWith
  • beea2f6 simplify nested if statements
  • 3e7edca add calledOnceWithExactly assertion

See the full diff

@rsimha
Copy link
Contributor

rsimha commented Feb 12, 2018

/to @erwinmombay

@rsimha rsimha merged commit f87cdad into master Feb 21, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/sinon-4.2.3 branch February 21, 2018 03:49
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* chore(package): update sinon to version 4.2.3

* chore(package): update lockfile

https://npm.im/greenkeeper-lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants