Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ 🏗️ Move cookie/getCookie/setCookie restrictions to conformance-config.textproto #13441

Merged

Conversation

danielrozenberg
Copy link
Member

Fixes #11978

@erwinmombay
Copy link
Member

good stuff!

Copy link
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rsimha rsimha merged commit 8ecd069 into ampproject:master Feb 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
@danielrozenberg danielrozenberg deleted the re-forbid-cookies-properly branch March 2, 2018 17:32
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants