Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Migrate origin whitelist to its own file #13489

Merged
merged 3 commits into from Feb 20, 2018

Conversation

newmuis
Copy link
Contributor

@newmuis newmuis commented Feb 14, 2018

No-op migration of origin whitelist to its own file, with the expectation that it will grow.

Copy link

@dreamofabear dreamofabear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Suggest origin-whitelist.js.

@newmuis
Copy link
Contributor Author

newmuis commented Feb 20, 2018

Done.

@newmuis newmuis merged commit a8bb62e into ampproject:master Feb 20, 2018
clawr pushed a commit to clawr/amphtml that referenced this pull request Feb 20, 2018
* Migrate origin whitelist to its own file.

* Rename whitelist.js to origin-whitelist.js and sort imports.

* Put origins one-per-line in whitelist.
protonate pushed a commit to protonate/amphtml that referenced this pull request Feb 26, 2018
* Migrate origin whitelist to its own file.

* Rename whitelist.js to origin-whitelist.js and sort imports.

* Put origins one-per-line in whitelist.
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* Migrate origin whitelist to its own file.

* Rename whitelist.js to origin-whitelist.js and sort imports.

* Put origins one-per-line in whitelist.
protonate pushed a commit to protonate/amphtml that referenced this pull request Mar 15, 2018
* Migrate origin whitelist to its own file.

* Rename whitelist.js to origin-whitelist.js and sort imports.

* Put origins one-per-line in whitelist.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants