Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLs protocols changed for inside scripts: from http to https #13736

Merged
merged 3 commits into from Mar 2, 2018
Merged

URLs protocols changed for inside scripts: from http to https #13736

merged 3 commits into from Mar 2, 2018

Conversation

sdbaron
Copy link
Contributor

@sdbaron sdbaron commented Mar 1, 2018

No description provided.

@mrjoro mrjoro requested a review from lannka March 1, 2018 21:33
@mrjoro
Copy link
Member

mrjoro commented Mar 1, 2018

Sending to @lannka since this looks like an ads change.

@sdbaron can you update the description of this PR, removing the template information and adding more context for what this PR is? also, if this is addressing an issue that's already been filed can you include a reference to that?

@lannka lannka added this to TODO in 3P Ads & Analytics Support via automation Mar 2, 2018
@lannka lannka merged commit 77904b2 into ampproject:master Mar 2, 2018
3P Ads & Analytics Support automation moved this from TODO to Done Mar 2, 2018
@sdbaron sdbaron changed the title CORS fixed 🔥 URLs protocols changed for inside scripts: from http to https Mar 2, 2018
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* -- videonow ad

* -- fixed CORS (strong https protocol) and added new parameter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants