Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Lightbox CSS API per spec #13754

Merged
merged 5 commits into from Mar 2, 2018

Conversation

cathyxz
Copy link
Contributor

@cathyxz cathyxz commented Mar 1, 2018

This is a revert of #13604, while maintaining the refactored CSS structure. We are no longer exposing a CSS API for launch #13565.

Copy link
Contributor

@aghassemi aghassemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's mention the PR# of what this is a revert of in the description.

@cathyxz cathyxz merged commit 08f6a8f into ampproject:master Mar 2, 2018
@cathyxz cathyxz deleted the feature/no-css-api branch March 2, 2018 03:03
RanAbram pushed a commit to RanAbram/amphtml that referenced this pull request Mar 12, 2018
* Remove unnecessary public css classes from lightbox

* Convert previously public css classes to private ones

* Remove public css classes

* important everything

* Remove css demo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants