Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️URL Replacements: Simplify AmpStoryVariables #13762

Merged
merged 4 commits into from Mar 14, 2018

Conversation

jridgewell
Copy link
Contributor

No description provided.

@jridgewell jridgewell requested a review from lannka March 2, 2018 02:08
@lannka lannka requested review from alanorozco and removed request for lannka March 2, 2018 18:31
/** @private {?number} */
this.pageId_ = null;
/** @private {boolean} */
this.initialized_ = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isInitialized

@jridgewell jridgewell merged commit bc582b1 into ampproject:master Mar 14, 2018
@jridgewell jridgewell deleted the url-replacements-4 branch March 14, 2018 19:55
@jridgewell jridgewell added this to To do in Build Size via automation Apr 9, 2018
@jridgewell jridgewell moved this from To do to Done in Build Size Apr 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Build Size
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants