inabox: add window.AMP.inaboxUnregisterIframe(iframe) #13795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
approved these changes
Mar 5, 2018
| measurableFrame: !HTMLIFrameElement, | ||
| observeUnregisterFn: (!UnlistenDef|undefined), | ||
| }} */ | ||
| let AdFrameDef; |
There was a problem hiding this comment.
typedefs are declared as let (they don't actually hold state)
| @@ -403,4 +404,51 @@ describes.realWin('inabox-host:messaging', {}, env => { | |||
| expect(host.getFrameElement_(sourceMock, sentinel)).to.be.null; | |||
| }); | |||
| }); | |||
|
|
|||
| describe('unregisterIframe', () => { | |||
| it('unregisters frames', () => { | |||
There was a problem hiding this comment.
nit: this test is kinda hard to look at. maybe add some line breaks or comments to separate setup / test / expectation verification?
lannka
approved these changes
Mar 5, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* inabox: add window.AMP.inaboxUnregisterIframe(iframe) * fix test error * fix test and add more coverage * PR feedback
jeffkaufman
added a commit
to jeffkaufman/amphtml
that referenced
this pull request
Mar 13, 2018
In ampproject#13795 we tried to fix a memory leak but missed that PositionObserver.observe(...) wasn't passing back the unregister function from Observable.add(), and so we weren't removing the listener. After this change we still leak on refresh: with examples/inabox.host.memory.html I measure us as leaking 200k in 60 refreshes without this PR, vs 30k with it. I'm still trying to figure out where else we leak, but getting the per-refresh leak down from 3k to 0.5k is still worth shipping.
keithwrightbos
pushed a commit
that referenced
this pull request
Mar 13, 2018
In #13795 we tried to fix a memory leak but missed that PositionObserver.observe(...) wasn't passing back the unregister function from Observable.add(), and so we weren't removing the listener. After this change we still leak on refresh: with examples/inabox.host.memory.html I measure us as leaking 200k in 60 refreshes without this PR, vs 30k with it. I'm still trying to figure out where else we leak, but getting the per-refresh leak down from 3k to 0.5k is still worth shipping.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clone of #13776 as Jeff OOTO. Modified to centralize state in single map to ease cleanup and future additions.
The current API for inabox is that when you want to remove a frame you delete it
from ampInaboxIframes. This means there isn't a way for inabox to run any
additional cleanup on frame removal, and currently there's a memory leak where
references to iframes (or their descendents) are maintained indefinitely in
InaboxMessagingHost.iframeMap_ and in the position observation listeners.
This changes the API from 'delete from a list of frames' to 'call a function',
which allows the function to do arbitrary cleanup like removing references.