fix(amp-user-notification): generate ampUserId by default
#1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
get-even-if-null
branch
2 times, most recently
from
2f964cc
to
bdd68ca
Compare
| The id will be the same for this user going forward, but no other requests | ||
| in AMP send the same id. | ||
| You can use the id on your side to lookup/store whether the user has | ||
| dismissed the notification before. | ||
| Please not that the value of `ampUserId` may be the string `null` if no |
erwinmombay
force-pushed
the
get-even-if-null
branch
from
bdd68ca
to
c269098
Compare
|
cc @Meggin for docs review |
|
@cramforce per discussion, changing this to no argument |
| The id will be the same for this user going forward, but no other requests | ||
| in AMP send the same id. | ||
| You can use the id on your side to lookup/store whether the user has | ||
| dismissed the notification before. | ||
| Please note that the value of `ampUserId` may be the string "null" if no | ||
| fallback cookie value was found. | ||
| - `showNotification` (boolean) - Boolean value wether the notification should be shown. |
There was a problem hiding this comment.
Spelling: 'wether' should be 'whether'. Also, I'd slightly re-word this: Boolean value indicating whether or not the notification should be shown.
|
lgtm once the two small comments have been actioned. |
erwinmombay
force-pushed
the
get-even-if-null
branch
from
c269098
to
da8c5ab
Compare
erwinmombay
changed the title
ampUserId may be the string nullampUserId by default
erwinmombay
force-pushed
the
get-even-if-null
branch
2 times, most recently
from
c0eec61
to
81daf9a
Compare
| return cid.get('amp-user-notification', | ||
| Promise.resolve(), this.dialogPromise_); | ||
| return cid.get( | ||
| {scope: 'amp-user-notification', createCookieIfNotPresent: true}, |
There was a problem hiding this comment.
@cramforce PTAL. (this is for amp-user-notification cid request)
There was a problem hiding this comment.
/cc @dvoytenko for additional review
|
LGTM |
|
Looks good to me. Pending others' comments. |
erwinmombay
force-pushed
the
get-even-if-null
branch
from
81daf9a
to
ed1bce3
Compare
erwinmombay
added a commit
that referenced
this pull request
Feb 11, 2016
fix(amp-user-notification): generate `ampUserId` by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.