馃悰 Wait for story impl to resolve #13829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
reviewed
Mar 6, 2018
| @@ -117,7 +120,7 @@ export class AmpStoryAutoAds extends AMP.BaseElement { | |||
| Services.extensionsFor(this.win)./*OK*/installExtensionForDoc( | |||
| ampdoc, MUSTACHE_TAG); | |||
|
|
|||
| ampStoryElement.getImpl().then(impl => { | |||
| this.storyImplPromise_ = ampStoryElement.getImpl().then(impl => { | |||
There was a problem hiding this comment.
you might just return this promise, it will block the lifecycle of the element.
but please test it out if i am right
There was a problem hiding this comment.
You are right. changed.
lannka
approved these changes
Mar 7, 2018
| @@ -71,6 +71,9 @@ export class AmpStoryAutoAds extends AMP.BaseElement { | |||
| constructor(element) { | |||
| super(element); | |||
|
|
|||
| /** @private {?Promise} */ | |||
| this.storyImplPromise_ = null; | |||
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* wait for story impl * block on buildCallback * remove unused var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
amp-story-auto-adshad a race condition where it was setting a pointer to theamp-storyimpl synchronously, even though thegetImpl()method is async.This wraps that bit of code in a promise.