Make sure safeframe geom matches gpt #13830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warrengm
suggested changes
Mar 6, 2018
| @@ -218,6 +218,13 @@ describes.realWin('DoubleClick Fast Fetch - Safeframe', realWinConfig, env => { | |||
| }); | |||
|
|
|||
| it('should get current geometry when safeframe fills amp-ad', () => { | |||
| sandbox./*OK*/stub(safeframeHost.baseInstance_, | |||
| 'getPageLayoutBox').returns({ | |||
| top: 0, | |||
There was a problem hiding this comment.
Could you update this to return a different value than iframeBox? As it is, the asserts won't fail if you reverted the changes in safeframe-host.js.
Same for other tests.
warrengm
approved these changes
Mar 6, 2018
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Make sure safeframe geom matches gpt * Respond to feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a mismatch between $sf.ext.geom().self on AMP pages and non-AMP pages. This should fix that.
On AMP pages, self was being measured relative to the top of the viewport. However, on non-amp pages self is measured relative to the top of the page.