<amp-pinterest> Sanitize URLs #13885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested changes
Mar 8, 2018
| @@ -58,9 +58,9 @@ export class PinWidget { | |||
| const log = el.getAttribute('data-pin-log'); | |||
| if (href) { | |||
| if (shouldPop) { | |||
| openWindowDialog(window, href, '_pinit', POP); | |||
| openWindowDialog(window, encodeURI(href), '_pinit', POP); | |||
There was a problem hiding this comment.
This won't do it. I can still use a javascript:alert('PWNED'), which'll pass right through. We likely want something like assertAbsoluteHttpOrHttpsUrl.
There was a problem hiding this comment.
Taken this out in favor of assertAbsoluteHttpOrHttpsUrl
nainar
commented
Mar 8, 2018
| @@ -57,6 +57,7 @@ export class PinWidget { | |||
| const href = el.getAttribute('data-pin-href'); | |||
| const log = el.getAttribute('data-pin-log'); | |||
| if (href) { | |||
| assertAbsoluteHttpOrHttpsUrl(href); | |||
There was a problem hiding this comment.
Asserting that the href is starting with http/https here.
Won't allow localhost - so testing 🤷
Also can one still force code in the latter part of the URL?
nainar
changed the title
jridgewell
approved these changes
Mar 8, 2018
|
Can you please merge it in too? I don't have the required rights. |
|
Ping me when travis passes. |
|
🔔🔔🔔 |
RanAbram
pushed a commit
to RanAbram/amphtml
that referenced
this pull request
Mar 12, 2018
* Encode all UR components to sanitize them * Assert that all URLs are http or https
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we call openWindowDialog on a click on an AMP widget. These
hrefs should be sanitized before being passed to openWindowDialog.