✨ Handle header names in a case-insensitive manner when metadata is ret… #13887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfrizzell
approved these changes
Mar 13, 2018
| @@ -72,9 +72,15 @@ export function metaJsonCreativeGrouper(callback) { | |||
| let first; | |||
| return function(line, done) { | |||
| if (first) { | |||
| const metadata = | |||
| /** @type {!Object<string, *>} */(tryParseJson(first) || {}); | |||
| const m = {}; | |||
There was a problem hiding this comment.
More descriptive name than m, please
keithwrightbos
approved these changes
Mar 13, 2018
|
Addressed review feedback. Thanks for the suggestion about Array.reduce! |
…urned in the line-delimited JSON HTML format.
|
All tests have now passed. Please merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…urned in the line-delimited JSON HTML format.
This affects SRA, and matches the behavior of the non-SRA case, when metadata is returned in actual HTTP response headers.