馃悰Handle connectedCallback when disconnected #13945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreamofabear
previously approved these changes
Mar 13, 2018
jridgewell
dismissed
dreamofabear鈥檚 stale review
Added more guards, please re-review.
Fixes ampproject#12849. Reverts part of ampproject#9432, since the bug is being addressed in runtime. Closes ampproject#9441, since root bug is being addressed.
jridgewell
force-pushed
the
connectedCallback-when-disconnected
branch
from
0679545
to
26bc7ee
Compare
dreamofabear
approved these changes
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12849.
Reverts part of #9432, since the bug is being addressed in runtime.
Closes #9441, since root bug is being addressed.