Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sinon to the latest version 馃殌 #13961

Merged
merged 2 commits into from Mar 14, 2018
Merged

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Mar 13, 2018

鈽濓笍 Greenkeeper鈥檚 updated Terms of Service will come into effect on April 6th, 2018.

Version 4.4.5 of sinon was just published.

Dependency sinon
Current Version 4.4.4
Type devDependency

The version 4.4.5 is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.

It might be worth looking into these changes and trying to get this project onto the latest version of sinon.

If you have a solid test suite and good coverage, a passing build is a strong indicator that you can take advantage of these changes directly by merging the proposed change into your project. If the build fails or you don鈥檛 have such unconditional trust in your tests, this branch is a great starting point for you to work on the update.


Commits

The new version differs by 5 commits.

  • 2fa34f6 Update docs/changelog.md and set new release id in docs/_config.yml
  • d048ad1 Add release documentation for v4.4.5
  • 41f0b83 4.4.5
  • d088fae Update History.md and AUTHORS for new release
  • 4751ee9 Add postinstall banner pointing to Open Collective

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@googlebot
Copy link

So there's good news and bad news.

馃憤 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

馃槙 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@rsimha rsimha merged commit 5e1d51e into master Mar 14, 2018
@greenkeeper greenkeeper bot deleted the greenkeeper/sinon-4.4.5 branch March 14, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants