Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-ad: Fix capirs ad initialisation 馃悰 #13988

Merged
merged 6 commits into from May 24, 2018

Conversation

pyxarez
Copy link
Contributor

@pyxarez pyxarez commented Mar 14, 2018

As mentioned in the docs, we should put ad in div[id="c"] container in order to avoid bugs.
That pr fixes appending to the body.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.

@pyxarez
Copy link
Contributor Author

pyxarez commented Mar 14, 2018

I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@pyxarez
Copy link
Contributor Author

pyxarez commented Mar 14, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@pyxarez pyxarez changed the title amp-ad: Fix capirs ad initialisation 馃悰 amp-ad: Fix capirs ad initialisation 馃悰 Mar 14, 2018
@pyxarez pyxarez force-pushed the amp-ad-capirs branch 2 times, most recently from 63e8ffd to 95c5251 Compare March 17, 2018 11:22
@pyxarez
Copy link
Contributor Author

pyxarez commented Mar 28, 2018

Hey! Is there someone to review PR:)

@zhouyx zhouyx added this to TODO in 3P Ads & Analytics Support via automation May 18, 2018
@ithinkihaveacat
Copy link
Contributor

@pyxarez The link to the docs doesn't work for me, is it correct? i.e. https://jira.rambler-co.ru/browse/SUP-36063.

@pyxarez
Copy link
Contributor Author

pyxarez commented May 23, 2018

@ithinkihaveacat, yea sorry that was a wrong link, but I just fixed it

@pyxarez
Copy link
Contributor Author

pyxarez commented May 23, 2018

@jasti jasti requested a review from lannka May 23, 2018 20:24
@lannka lannka self-assigned this May 24, 2018
@lannka lannka merged commit 37a4a54 into ampproject:master May 24, 2018
3P Ads & Analytics Support automation moved this from TODO to Done May 24, 2018
@pyxarez pyxarez deleted the amp-ad-capirs branch October 11, 2018 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants