New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
amp-ad: Fix capirs ad initialisation 馃悰 #13988
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
I signed it! |
CLAs look good, thanks! |
63e8ffd
to
95c5251
Compare
Hey! Is there someone to review PR:) |
@pyxarez The link to the docs doesn't work for me, is it correct? i.e. https://jira.rambler-co.ru/browse/SUP-36063. |
@ithinkihaveacat, yea sorry that was a wrong link, but I just fixed it |
I mean that part of documentation https://github.com/ampproject/amphtml/blob/master/ads/README.md#the-iframe-sandbox |
As mentioned in the docs, we should put ad in
div[id="c"]
container in order to avoid bugs.That pr fixes appending to the body.