Subscriptions: reset the state on action and limit viewers where linking can be done #14013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekbh
approved these changes
Mar 15, 2018
prateekbh
reviewed
Mar 15, 2018
| // This is a very light veiwer resolution since there's no real security | ||
| // implication - this only affects on-platform preferences. | ||
| const viewerUrl = viewer.getParam('viewerUrl'); | ||
| if (viewerUrl) { |
There was a problem hiding this comment.
why do we need 2 different blocks?
cant we just call viewer.getViewerOrigin().then(origin => { and assume that is resolves immediately if viewerUrl is already available?
There was a problem hiding this comment.
The comment above explains it. Unfortunately this is a pretty tough situation. The action execution must be synchronous, otherwise we get hit with a popup blocker. Thus I'm trying to resolve one as soon as possible and the other can wait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.