Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greenkeeper/sinon 4.4.5 #14015

Closed

Conversation

ptrpovtyu
Copy link

Instructions:

  • Pick a meaningful title for your pull request. (Use sentence case.)
    • Prefix the title with an emoji to identify what is being done. (Copy-paste from the list below.)
    • Do not overuse punctuation in the title (like (chore):).
    • If it is helpful, use a simple prefix (like ProjectX: Implement some feature).
  • Enter a succinct description that says why the PR is necessary, and what it does.
    • Mention the GitHub issue that is being addressed by the pull request.
    • The keywords Fixes, Closes, or Resolves followed the issue number will automatically close the issue.

Example of a good description:

  • Implements aspect X
  • Leaves out feature Y because of A
  • Improves performance by B
  • Improves accessibility by C

Emojis for categorizing pull requests:

โœจ New feature (:sparkles:)
๐Ÿ› Bug fix (:bug:)
๐Ÿ”ฅ P0 fix (:fire:)
โœ… Tests (:white_check_mark:)
๐Ÿš€ Performance improvements (:rocket:)
๐Ÿ– CSS / Styling (:crayon:)
โ™ฟ Accessibility (:wheelchair:)
๐ŸŒ Internationalization (:globe_with_meridians:)
๐Ÿ“– Documentation (:book:)
๐Ÿ— Infrastructure / Tooling / Builds / CI (:building_construction:)
โช Reverting a previous change (:rewind:)
โ™ป๏ธ Refactoring (like moving around code w/o any changes) (:recycle:)
๐Ÿšฎ Deleting code (:put_litter_in_its_place:)

@googlebot
Copy link

So there's good news and bad news.

๐Ÿ‘ The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

๐Ÿ˜• The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants