-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Greenkeeper/sinon 4.4.5 #14015
Greenkeeper/sinon 4.4.5 #14015
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:diff:20180305 Latest report for ptrpov/amphtml: https://snyk.io/test/github/ptrpov/amphtml
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/npm:diff:20180305 Latest report for ptrpov/amphtml: https://snyk.io/test/github/ptrpov/amphtml
So there's good news and bad news. ๐ The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. ๐ The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Instructions:
(chore):
).ProjectX: Implement some feature
).Fixes
,Closes
, orResolves
followed the issue number will automatically close the issue.Example of a good description:
Emojis for categorizing pull requests:
โจ New feature (
:sparkles:
)๐ Bug fix (
:bug:
)๐ฅ P0 fix (
:fire:
)โ Tests (
:white_check_mark:
)๐ Performance improvements (
:rocket:
)๐ CSS / Styling (
:crayon:
)โฟ Accessibility (
:wheelchair:
)๐ Internationalization (
:globe_with_meridians:
)๐ Documentation (
:book:
)๐ Infrastructure / Tooling / Builds / CI (
:building_construction:
)โช Reverting a previous change (
:rewind:
)โป๏ธ Refactoring (like moving around code w/o any changes) (
:recycle:
)๐ฎ Deleting code (
:put_litter_in_its_place:
)